36 replies to this topic

[Inubashiri]

this is not the problem.

1. say there is a trade going on. deal window has to store the amount of money you're giving for an item. if it's an int (hasn't been changed) correct sum won't be possible over 2+ billion.

this is just one example of how this can go wrong. I'm sure there are places where double -> int downgrading can hurt the game..

This is not a 10 minute project, in other words.

What part of there is no down casting do you not understand? The only time zeny is recalculated is when there its an addition or subtraction by whatever means (deals, purchases, selling, buying, quest related, skills, etc). A double has 53 significant digits as opposed to an int which has 10. I fail to how in the world you would ever overflow on a double. I never suggested it was a 10 min fix, but it has far less code additions and if they were smart they have a common method for zeny transactions.

Edited by Inubashiri, 10 July 2012 - 07:04 AM.

[sniperkenny]

ok , since you have no imagination, let me write it down:

player1 --> deal window <-- player 2

player 1 puts 4 billion in a deal window (not in the other players account right away) so if it's an int type you have error.
Unless it works the other way.
Learn to read exactly what people are trying to say.

---
They might have been smart, but 10 years ago they had far less tools to code with.

Edited by sniperkenny, 10 July 2012 - 07:09 AM.

[Inubashiri]

The situation you just described won't happen, trade window zeny is capped at 999,999,999 so 4b would be replaced

Just upgrading to unsigned integers would be a huge improvement. 2.1b would become 4.2b.

Also 10 years ago we had databases and compilers just the same, not sure what other tools you're referring to. I know this because I was using them.

[DeltaRay]

I like Rens Idea ALOT
I wonder couldnt u do this with items too?
trade in 1000 white slims for 1 coin (0 weight) and that coin u can trade it in for 1000 slims all it does make it easier to deal to ppl.

[sv003]

The issue with items vs zeny. Items can fluctuate in value (zeny wise) while 1z is always going to be 1z.

[renouille]

That's not a problem--they would be just like quivers. I don't think it's possible to preserve named items that way though.

[Inubashiri]

I would be more concerned with dupes

[Riakuta]

This idea isn't very practical, but a NPC buyable item called Gold Coin for 100,000,000z (75,000,000z) Haggle and can be sold to NPC for 50,000,000z (62,000,000) Overcharge?

Edited by Riakuta, 10 April 2013 - 08:29 PM.

[Inubashiri]

Creating an item to fix something that isn't broken is counter productive. The datatype of zeny needs to be updated to a higher non-signed storage type.

[jshun123]

Basically call gm when dealing over 1b?
Isnt that just more work for gms any way? =/

[Inubashiri]

You can

[Lyrage]

Regular zeny drain events would be a lot of help on this issue.

Lifting the 2B ceiling is like encouraging those botters to bot more since characters would now be able to hold tons of zeny.

Just my 2 cents.